-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Split-up stability_index query #143845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Split-up stability_index query #143845
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Split-up stability_index query r? `@ghost` for perf
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (5597f02): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.9%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.0%, secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 466.126s -> 464.517s (-0.35%) |
609a38d
to
89747b9
Compare
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
89747b9
to
2890684
Compare
This PR aims to move deprecation and stability processing away from the monolithic
stability_index
query, and directly implementlookup_{deprecation,stability,body_stability,const_stability}
queries.The basic idea is to:
check_attr.rs
;MissingStabilityAnnotations
visitor;Annotator
visitor and thestability_index
query.The first commit contains functional change, and now warns when
#[automatically_derived]
is applied on a non-trait impl block. The other commits should not change visible behaviour.Perf in #143845 (comment) shows small but consistent improvement, except for unused-warnings case. That case being a stress test, I'm leaning towards accepting the regression.
This PR changes
check_attr
, so has a high conflict rate on that file. This should not cause issues for review.